Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json5-parser] Fix build, cleanup #41142

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 24, 2024

No description provided.

@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 24, 2024

FTR last upstream change was SEVEN years ago.

Fixes error in https://dev.azure.com/vcpkg/public/_build/results?buildId=107188&view=artifacts&pathAsName=false&type=publishedArtifacts:

CMake Error in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 3.29)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".


-- Configuring incomplete, errors occurred!

@dg0yt dg0yt mentioned this pull request Sep 24, 2024
6 tasks
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Sep 24, 2024
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2024
@JavierMatosD JavierMatosD merged commit 08ef4d0 into microsoft:master Sep 24, 2024
16 checks passed
@dg0yt dg0yt deleted the json5-parser branch September 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants