-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-base & qtbase] Fix error on arm64-windows #41536
Conversation
Patch by Oliver Wolff: qt/qtbase@b66ecb2 qmake has been fixed in 6.8, but all other versions need to be patched for arm64. The original report is about qt5-base: Build error on arm64-windows. but this PR also adds the same patch to Qt6.
you need to bump (add a 1 to the number there or create it with value 1 if missing) "port-version" for both qt5-base/vcpkg.json and qtbase/vcpkg.json |
and vcpkg team should move to test arm64_windows on real arm64_windows ;) |
|
Hi! Thanks everyone for the feedback. What do you mean, that the CI build of 'arm64_windows` is not performed on real ARM64 hardware, or in Windows OS? I did build Qt5 locally on my new Surface Pro 11, with Snapdragon® X Elite and Windows 11. I want to use this device to port and test my software to windows+arm64. That is why I've opened this PR. The build time on the CI server ( qt5-base:x64-windows: SUCCEEDED: 8 min) is good enough for me, and matches the build time I got on the Surface. |
vcpkg CI does arm64-windows as a cross build on x64-windows. So there is no native testing on arm64 windows hosts. (And some ports are hard to adapt to vcpkg's cross-build pattern. |
Can somebody tell me why the |
in the azure pipeline you can find everything. |
Thanks. I see that there is a missing header that couldn't be installed. It does not explain why yesterday the same build succeeded. |
The patches here were not authored by me. These were the original headers: From b66ecb295ecc3981b1c21f01d62c9066f5d6e6ca Mon Sep 17 00:00:00 2001 From: Oliver Wolff <oliver.wolff@qt.io> Date: Mon, 15 Jul 2024 09:31:30 +0200 Subject: [PATCH 1/1] qmake: Add support for arm64 hosts on Windows Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
/azp run |
Rerunning due to network mistake last night. |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
Patch by Oliver Wolff:
qt/qtbase@b66ecb2
qmake has been fixed in 6.8, but all other versions need to be patched for arm64.
The original report is about qt5-base: Build error on arm64-windows. but this PR also adds the same patch to Qt6.
Fixes #37210