Patch Tuesday for November 2024 #42165

BillyONeal · 2024-11-14T23:25:28Z

Move Azure Region WestUS3 -> WestUS
Update Visual Studio to 17.11.6.
Update the Windows SDK to the current version. This required working around https://developercommunity.visualstudio.com/t/NAN-is-no-longer-compile-time-constant-i/10688907 in a few ports
Update PowerShell to 7.4.6.
Update Azure-CLI to 2.66.0.
Remove the WDK as this appears to be unused.
Synchronize the Linux image minting JSON with as-deployed.
Upgrade from PublishBuildArtifacts@1 to PublishPipelineArtifact@1
Add arm64-windows-static-md as requested by Azure Core.
Fixed [chartdir]'s supports expression to match its portfile.cmake.
Fixed [freeopcua] needing /bigobj and combined patches of patches.
Enabled ports skipped for not having 'stable download URLs' now that we have asset caching.

…e using.

BillyONeal · 2024-11-14T23:26:20Z

I forgot to make the Azure DevOps changes. Will deploy that and reopen.

BillyONeal · 2024-11-15T01:35:32Z

/azp run

azure-pipelines · 2024-11-15T01:35:41Z

Azure Pipelines successfully started running 1 pipeline(s).

scripts/azure-pipelines/windows/deploy-visual-studio.ps1

…patches.

…static-md.

…0 SDK back.

…e-WebRequest.

BillyONeal · 2024-11-19T17:44:23Z

/azp run

azure-pipelines · 2024-11-19T17:44:33Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2024-11-19T18:51:42Z

##[error]Artifact cannot be uploaded because max quantity has been exceeded or the payment instrument is invalid. https://aka.ms/artbilling for details.

I asked on an internal mailing list if this is expected.

I fixed this by 'setting up billing' but given that pipeline artifacts are documented to be unbillable it seems like a bug in either the product or the docs, I reported.

BillyONeal · 2024-11-19T19:16:25Z

Closed and reopened to kick CLABot

BillyONeal · 2024-11-19T19:22:20Z

ports/freeopcua/boost-compatibility.patch

+   , Callback(callback)
+   , io(service.GetIOService())
+-  , Timer(io, boost::posix_time::milliseconds(data.RevisedPublishingInterval))
+  , Timer(io, boost::posix_time::milliseconds((int)data.RevisedPublishingInterval))


This part used to be in ports/freeopcua/improve_compatibility_with_recent_boost.patch

BillyONeal · 2024-11-19T19:22:42Z

ports/freeopcua/boost-compatibility.patch

+     typedef std::promise<void> Promise;
+     Promise promise;
+#if BOOST_VERSION >= 107000
+    boost::asio::post(Socket.get_executor(), bind(&Promise::set_value, &promise));


This part used to be in boost-1.70.patch

BillyONeal · 2024-11-19T19:23:29Z

ports/freeopcua/boost-compatibility.patch

@@ -51,14 +99,8 @@ index d42aa65..dd193a9 100644
 #include <boost/thread/shared_mutex.hpp>
 #include <chrono>
 #include <iostream>
-@@ -115,5 +115,3 @@ private:
-
- }


Several of these patches were removing trailing whitespace from the file, I minimized the patch by dropping that edit.

BillyONeal · 2024-11-19T19:27:17Z

/azp run

azure-pipelines · 2024-11-19T19:27:26Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2024-11-19T19:29:30Z

ports/freeopcua/cmakelists_fixes.patch

@@ -68,11 +68,12 @@ index de03564..df3fcf6 100644
 -    #set(CMAKE_SHARED_LINKER_FLAGS "--no-undefined" )
 +    add_definitions(-D_SCL_SECURE_NO_WARNINGS)
 +    add_definitions(-D_CRT_SECURE_NO_WARNINGS)
+    add_compile_options(/bigobj)


The main reason I touched this port was to add this /bigobj because that's what the comment in ci.baseline.txt said it needed, and that appears to be correct :)

Neumann-A · 2024-11-23T21:19:55Z

@BillyONeal: Any tips to make easyhook work? I simply cannot get it to pass the post build checks. What exactly needs to be installed by VS?

BillyONeal · 2024-11-25T20:22:00Z

@BillyONeal: Any tips to make easyhook work? I simply cannot get it to pass the post build checks. What exactly needs to be installed by VS?

It's currently working in CI. When it failed before it complained about .NET targeting stuff not being installed.

Neumann-A · 2024-11-27T22:45:46Z

It's currently working in CI. When it failed before it complained about .NET targeting stuff not being installed.

Did it really complain about that or did it fail because the EasyHook.dll does not export any symbols?

BillyONeal · 2024-11-28T00:32:39Z

Did it really complain about that or did it fail because the EasyHook.dll does not export any symbols?

It failed because easyhook explicitly asks for .NET things in its build system.

BillyONeal · 2024-11-28T00:34:12Z

MSBuild version 17.11.9+a69bbaaf5 for .NET Framework
Build started 11/15/2024 3:36:06 PM.

     1>Project "D:\b\easyhook\x64-windows-rel\EasyHook.sln" on node 1 (EasyHookDll target(s)).
     1>ValidateSolutionConfiguration:
         Building solution configuration "netfx4-Release|x64".
       ValidateProjects:
         The project "EasyHook.Tests" is not selected for building in solution configuration "netfx4-Release|x64".
     1>Project "D:\b\easyhook\x64-windows-rel\EasyHook.sln" (1) is building "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (2) on node 1 (default targets).
     2>Project "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (2) is building "D:\b\easyhook\x64-windows-rel\EasyHookSvc\EasyHookSvc.csproj" (3:2) on node 1 (default targets).
     3>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [D:\b\easyhook\x64-windows-rel\EasyHookSvc\EasyHookSvc.csproj]
     3>_CleanRecordFileWrites:
         Creating directory "obj\netfx4-Release\".
     3>Done Building Project "D:\b\easyhook\x64-windows-rel\EasyHookSvc\EasyHookSvc.csproj" (default targets) -- FAILED.
     2>Project "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (2) is building "D:\b\easyhook\x64-windows-rel\EasyHook\EasyHook.csproj" (4:2) on node 2 (default targets).
     4>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [D:\b\easyhook\x64-windows-rel\EasyHook\EasyHook.csproj]
     4>_CleanRecordFileWrites:
         Creating directory "obj\netfx4-Release\".
     4>Done Building Project "D:\b\easyhook\x64-windows-rel\EasyHook\EasyHook.csproj" (default targets) -- FAILED.
     2>Done Building Project "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "D:\b\easyhook\x64-windows-rel\EasyHook.sln" (EasyHookDll target(s)) -- FAILED.

Build FAILED.

       "D:\b\easyhook\x64-windows-rel\EasyHook.sln" (EasyHookDll target) (1) ->
       "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (default target) (2) ->
       "D:\b\easyhook\x64-windows-rel\EasyHookSvc\EasyHookSvc.csproj" (default target) (3:2) ->
       (GetReferenceAssemblyPaths target) -> 
         C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [D:\b\easyhook\x64-windows-rel\EasyHookSvc\EasyHookSvc.csproj]


       "D:\b\easyhook\x64-windows-rel\EasyHook.sln" (EasyHookDll target) (1) ->
       "D:\b\easyhook\x64-windows-rel\EasyHookDll\EasyHookDll.vcxproj" (default target) (2) ->
       "D:\b\easyhook\x64-windows-rel\EasyHook\EasyHook.csproj" (default target) (4:2) ->
         C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [D:\b\easyhook\x64-windows-rel\EasyHook\EasyHook.csproj]

    0 Warning(s)
    2 Error(s)

Time Elapsed 00:00:00.71

BillyONeal added 10 commits November 13, 2024 15:24

Update VS to 17.11.6, and remove some older components we shouldn't b…

d693164

…e using.

Update pwsh to v7.4.6

a583ad0

Update Azure-CLI to 2.66.0

18bd371

Remove the WDK.

fdf8786

Add Linux apt update (as already deployed).

6387abd

Upgrade Android docker container to Noble.

3044c3e

Move to WestUS

60e04c0

More move to westus.

1b432bb

Upgrade to PublishPipelineArtifact.

1425f91

Update image.

3b3bdee

BillyONeal closed this Nov 14, 2024

More move to westus.

67a5531

BillyONeal reopened this Nov 15, 2024

Promote arm64-windows-static-md as requested by Azure Core.

07e34e8

BillyONeal mentioned this pull request Nov 15, 2024

Android CI with JDK, SDK, API level 28, dynamic CRT linkage #42080

Draft

WangWeiLin-MV assigned MonicaLiu0311 Nov 15, 2024

MonicaLiu0311 added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Nov 15, 2024

JavierMatosD previously approved these changes Nov 15, 2024

View reviewed changes

Neumann-A reviewed Nov 15, 2024

View reviewed changes

scripts/azure-pipelines/windows/deploy-visual-studio.ps1 Outdated Show resolved Hide resolved

BillyONeal commented Nov 15, 2024

View reviewed changes

scripts/azure-pipelines/windows/deploy-visual-studio.ps1 Show resolved Hide resolved

BillyONeal added 6 commits November 15, 2024 12:50

Merge remote-tracking branch 'origin/master' into patch-tuesday-2024-11

8d1c118

[freeopcua] Fix arm64-windows build, combine boost patches, minimize …

3217b44

…patches.

Duplicate all arm64-windows ci.baseline.txt entries as arm64-windows-…

ad677cc

…static-md.

Upgrade Windows 11 SDK as suggested by @Neumann-A , and put Windows 1…

d9a0f21

…0 SDK back.

Update Windows image again.

07fddbb

Try to improve reliability by switching to curl.exe rather than Invok…

7475080

…e-WebRequest.

BillyONeal added 5 commits November 18, 2024 22:39

Merge remote-tracking branch 'origin/master' into patch-tuesday-2024-11

1abfaf6

[gdal] Remove /machine flag.

dcf8a70

Fix another ci.baseline.txt typo.

8139447

Also OpenMVS

15fd43d

Version DB

9c9e970

BillyONeal closed this Nov 19, 2024

BillyONeal reopened this Nov 19, 2024

BillyONeal commented Nov 19, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into patch-tuesday-2024-11

2ae5bd5

vicroms approved these changes Nov 19, 2024

View reviewed changes

BillyONeal enabled auto-merge (squash) November 19, 2024 20:53

BillyONeal merged commit 0857a4b into microsoft:master Nov 19, 2024
17 checks passed

BillyONeal deleted the patch-tuesday-2024-11 branch November 19, 2024 23:43

MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 20, 2024

dg0yt mentioned this pull request Nov 20, 2024

[librttopo] Build error on x64-windows #42200

Closed

chrstnbwnkl mentioned this pull request Nov 25, 2024

Fix win build workflow valhalla/valhalla#4993

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch Tuesday for November 2024 #42165

Patch Tuesday for November 2024 #42165

BillyONeal commented Nov 14, 2024 •

edited

Loading

BillyONeal commented Nov 14, 2024

BillyONeal commented Nov 15, 2024

azure-pipelines bot commented Nov 15, 2024

BillyONeal commented Nov 19, 2024

azure-pipelines bot commented Nov 19, 2024

BillyONeal commented Nov 19, 2024

BillyONeal commented Nov 19, 2024

BillyONeal Nov 19, 2024

BillyONeal Nov 19, 2024

BillyONeal Nov 19, 2024

BillyONeal commented Nov 19, 2024

azure-pipelines bot commented Nov 19, 2024

BillyONeal Nov 19, 2024

Neumann-A commented Nov 23, 2024

BillyONeal commented Nov 25, 2024

Neumann-A commented Nov 27, 2024

BillyONeal commented Nov 28, 2024

BillyONeal commented Nov 28, 2024

Patch Tuesday for November 2024 #42165

Patch Tuesday for November 2024 #42165

Conversation

BillyONeal commented Nov 14, 2024 • edited Loading

BillyONeal commented Nov 14, 2024

BillyONeal commented Nov 15, 2024

azure-pipelines bot commented Nov 15, 2024

BillyONeal commented Nov 19, 2024

azure-pipelines bot commented Nov 19, 2024

BillyONeal commented Nov 19, 2024

BillyONeal commented Nov 19, 2024

BillyONeal Nov 19, 2024

Choose a reason for hiding this comment

BillyONeal Nov 19, 2024

Choose a reason for hiding this comment

BillyONeal Nov 19, 2024

Choose a reason for hiding this comment

BillyONeal commented Nov 19, 2024

azure-pipelines bot commented Nov 19, 2024

BillyONeal Nov 19, 2024

Choose a reason for hiding this comment

Neumann-A commented Nov 23, 2024

BillyONeal commented Nov 25, 2024

Neumann-A commented Nov 27, 2024

BillyONeal commented Nov 28, 2024

BillyONeal commented Nov 28, 2024

BillyONeal commented Nov 14, 2024 •

edited

Loading