Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcbor,libfido2] Fix on non-Windows, cleanup #42341

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 24, 2024

No description provided.

@dg0yt dg0yt force-pushed the libcbor branch 2 times, most recently from fa2b047 to e24817d Compare November 24, 2024 20:23
HEAD_REF master
PATCHES cmake-config.diff
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream: PJK/libcbor#337

@dg0yt dg0yt marked this pull request as ready for review November 24, 2024 21:21
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 25, 2024
@MonicaLiu0311
Copy link
Contributor

libcbor

The usage test passed on x64-windows (header files found).

libfido2

Find the header files through the pc file.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 25, 2024
@BillyONeal BillyONeal changed the title [libcbor,libfido2] Fix, cleanup [libcbor,libfido2] Fix on non-Windows, cleanup Nov 25, 2024
@BillyONeal BillyONeal merged commit 76450ca into microsoft:master Nov 25, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

@dg0yt dg0yt deleted the libcbor branch November 26, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants