Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arrow] Update to 18.1.0 #42357

Merged
merged 8 commits into from
Dec 3, 2024
Merged

[arrow] Update to 18.1.0 #42357

merged 8 commits into from
Dec 3, 2024

Conversation

amoeba
Copy link
Contributor

@amoeba amoeba commented Nov 26, 2024 •
edited by jimwang118
Loading

Fixes #42369

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Nov 26, 2024
@amoeba
Copy link
Contributor Author

amoeba commented Nov 26, 2024

@microsoft-github-policy-service agree

@LilyWangLL
Copy link
Contributor

Please fix the build error of arrow:x64-android and arrow:arm64-android, you could download the faiure log from https://dev.azure.com/vcpkg/public/_build/results?buildId=109678&view=artifacts&pathAsName=false&type=publishedArtifacts.

@LilyWangLL LilyWangLL marked this pull request as draft November 29, 2024 06:42
@amoeba amoeba mentioned this pull request Nov 29, 2024
Closed
@amoeba
Copy link
Contributor Author

amoeba commented Nov 29, 2024

I've filed apache/arrow#44886 to track the process of figuring out a fix. I'll post an update here once we have a fix.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 30, 2024

Note that vcpkg CI builds Android with API level 21. At that level, C runtime is very incomplete. It might be necessary to record an expected fail in scripts/ci.baseline.txt.

@amoeba
Copy link
Contributor Author

amoeba commented Nov 30, 2024

I pushed up a patch for the Android failure and will keep an eye on CI now.

dg0yt
dg0yt reviewed Nov 30, 2024
View reviewed changes
ports/arrow/portfile.cmake Outdated
Comment on lines 14 to 15
0004_android.patch
0005_android.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch names 🥹

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if you're requesting a change here or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in the position to request changes, but IMHO it is not good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to give any guidance on what would be good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. 0006-android-datetime.patch.

(But I still wonder if patching a vendored datetime is the right thing to start with.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: the filenames, I pushed changes to the filenames.

@amoeba
Copy link
Contributor Author

amoeba commented Dec 1, 2024

@LilyWangLL we added a patch to the portfile and that looks like it's fixed the two failing jobs from before. I'm seeing the microsoft.vcpkg.pr (x86 windows) job fail but it looks related. Can you take a look and let us know if there's anything else that needs to be done here?

By the way, we plan to upstream the patch and remove it from this port in a future update, see apache/arrow#43390.

dg0yt
dg0yt reviewed Dec 1, 2024
View reviewed changes
versions/a-/arrow.json Outdated Show resolved Hide resolved
@amoeba @dg0yt
Update versions/a-/arrow.json
de155ae 
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@amoeba amoeba marked this pull request as ready for review December 2, 2024 19:34
@BillyONeal BillyONeal merged commit 4353b6e into microsoft:master Dec 3, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 3, 2024
@amoeba
Copy link
Contributor Author

amoeba commented Dec 3, 2024

Thanks for the merge @BillyONeal and for the reviews @dg0yt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arrow update to 18.1.0
4 participants
@amoeba @LilyWangLL @dg0yt @BillyONeal