Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qtquick3d,openxr-loader] Fix config, control dependency #42588

Merged
merged 8 commits into from
Dec 9, 2024
Merged

[vcpkg baseline][qtquick3d,openxr-loader] Fix config, control dependency #42588

merged 8 commits into from
Dec 9, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 7, 2024 •
edited
Loading

openxr-loader can be built directly from the "Source" repo. No need to maintain separate patches.

@dg0yt dg0yt mentioned this pull request Dec 7, 2024
Closed
7 tasks
@dg0yt dg0yt changed the title [qtquick3d] OpenXR [qtquick3d,openxr-loader] Fix config, control dependency Dec 7, 2024
@dg0yt dg0yt marked this pull request as ready for review December 7, 2024 18:50
@dg0yt dg0yt changed the title [qtquick3d,openxr-loader] Fix config, control dependency [vcpkg baseline][qtquick3d,openxr-loader] Fix config, control dependency Dec 8, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 9, 2024
@dg0yt dg0yt mentioned this pull request Dec 9, 2024
Open
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Dec 9, 2024
@jimwang118
Copy link
Contributor

All feature and usage test passed with x64-windows triplet.

@BillyONeal BillyONeal merged commit 061862c into microsoft:master Dec 9, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

@dg0yt dg0yt deleted the xr branch December 10, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @jimwang118 @BillyONeal @MonicaLiu0311