Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gstreamer] Fix multiple definition of functions #42638

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

jimwang118
Copy link
Contributor

Fix the following error.

/usr/bin/ld: /mnt/vcpkg/installed/x64-linux/debug/lib/pkgconfig/../../lib/libsndfile.a(g72x.c.o): in function `step_size':
/mnt/vcpkg/buildtrees/libsndfile/src/1.2.2-fa730f3d73.clean/src/G72x/g72x.c:299: multiple definition of `step_size'; subprojects/gst-plugins-bad/gst/siren/libgstsiren.a(common.c.o):/mnt/vcpkg/buildtrees/gstreamer/x64-linux-dbg/../src/1.24.7-08ef53880b/subprojects/gst-plugins-bad/gst/siren/common.c:47: first defined here
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The feature sndfile test passed with x64-linux and x64-windows triplets.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 11, 2024
@jimwang118 jimwang118 marked this pull request as ready for review December 12, 2024 07:40
@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Dec 16, 2024
};

-float step_size[8] = {
+float stp_size[8] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something that should be committed upstream. Has upstream been notified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted issue 3761 upstream but have not received a response.

@JavierMatosD JavierMatosD marked this pull request as draft December 16, 2024 15:59
@Mengna-Li Mengna-Li removed the info:reviewed Pull Request changes follow basic guidelines label Dec 17, 2024
@JavierMatosD JavierMatosD marked this pull request as ready for review December 17, 2024 19:51
@JavierMatosD JavierMatosD merged commit a258b5e into microsoft:master Dec 17, 2024
17 checks passed
@jimwang118 jimwang118 deleted the fix-multiple-func branch December 18, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants