[pcl] Fix PCL install with HEAD #4528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pcl install with --head by splitting find_flann.patch.
|
LGTM Thanks 👍 |
|
I would suggest to wait @KirbX to test it and wait ack. |
|
PCL 1.9.0 has been released! It will solve many problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of this patch (find_flann.patch#L16-L24) is already merged in upstream head.
Therefor, This patch doesn't apply when vcpkg install pcl with
--head.But, The first part of this patch (find_flann.patch#L5-L15) will continue to be necessary.
This pull request will fix pcl install with
--headby splitting find_flann.patch.PointCloudLibrary/pcl#2545