Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CppZMQ library version leveraged to 4.3.0. #4822

Merged

Conversation

machpavel
Copy link
Contributor

Updates CppZMQ library to version 4.3.0. This resolves CMake issue: #3356

@msftclas
Copy link

msftclas commented Nov 26, 2018

CLA assistant check
All CLA requirements met.

@ras0219-msft ras0219-msft self-assigned this Nov 26, 2018
@3kwa
Copy link

3kwa commented Nov 28, 2018

I discovered vcpkg an hour ago and bumped into #3356 from the get go so am very excited about this. How & when will that be released?

PS: thanks a lot for vcpkg it saved my day!

@machpavel
Copy link
Contributor Author

@3kwa I don't know when this will be merged into master branch, but in the meantime, you can always checkout my branch...

@ras0219-msft
Copy link
Contributor

Thanks for the PR, looks great!

This regressed Windows (interestingly enough) due to the tests. We currently do not build tests for libraries, so I've disabled that along with slightly tweaking the installed cmake files.

Assuming this CI passes, LGTM!

@ras0219-msft ras0219-msft merged commit e1b5375 into microsoft:master Dec 5, 2018
@ras0219-msft
Copy link
Contributor

Thanks again!

@machpavel
Copy link
Contributor Author

You are very welcome!

@machpavel machpavel deleted the Lever-cppzmq-version-to-4.3.0 branch December 5, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants