[lz4, flann] port patches from #5169

[cenit]

No description provided.

[NancyLi1013]

Hi @cenit, here are some regressions from the current system:

x64-windows	master	test	notes
flann	Pass	Fail	Regression

x64-windows-static	master	test	notes
pcl	Pass	Fail	Regression

arm64-windows	master	test	notes
flann	Pass	Fail	Regression

x86-windows	master	test	notes
flann	Pass	Fail	Regression

x64-uwp	master	test	notes
flann	Pass	Fail	Regression

arm-uwp	master	test	notes
flann	Pass	Fail	Regression

failureLogs.zip

[vicroms]

Hi @cenit

These are the latest failure logs

x64-windows	master	test	notes
openmvg	Pass	Fail	Regression

x64-windows-static	master	test	notes
pcl	Pass	Fail	Regression

x86-windows	master	test	notes
pcl	Pass	Fail	Regression
openmvg	Pass	Fail	Regression

On the bright side, flann now works for 64-bit Linux

x64-linux	master	test	notes
flann	Fail	Pass

[cenit]

@vicroms any update here? Is only pcl broken now? (Already saw some necessary fixes for it)

[vicroms]

Good guess, pcl is the only regression left.

Failure Logs

x86-windows	master	test	notes
pcl	Pass	Fail	Regression

[cenit]

It should fail everywhere... not just x86-windows. But thanks!

(Maybe it is regressing only on x86-windows, which was building ok somehow...)

[cenit]

@vicroms I need the logs whenever you have time. I am able to build pcl locally, so I need an update on regressions.

[vicroms]

Hi @cenit

Sorry for the delay, I thought I had replied to this PR :S

Failure logs

Current status:

• flann works on Linux now, and
• pcl is getting skipped on all platforms except x86-windows and x64-windows-static.

I'll take a look at pcl's dependencies to find which are causing the build to be skipped.

[cenit]

green check 😃

[ras0219-msft]

@vicroms It looks like qhull is preventing pcl from being built for x64-windows:

qhull:x64-windows:       fail: 405172dc5986a116b31314fefd7ed4ffcac63810

Edit: The qhull build appears to have failed due to some disk issue. I've purged the failure and re-queued (though I expect we'll still get a green check :))

[vicroms]

Thanks @cenit

Looks like everything has been sorted out in this PR.