Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gettext]Support Linux and OSX build #8692

Closed

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 22, 2019

  • Support Linux Build
  • Support OSX Build
  • Modify dependencies
  • test

@JackBoosY JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. wip labels Oct 22, 2019
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 22, 2019

@Neumann-A @voskrese Could you test it?
I don't think these files generated now is complete.

@PhoebeHui PhoebeHui self-assigned this Jan 14, 2020
@past-due
Copy link
Contributor

past-due commented Mar 4, 2020

I'm not sure this approach is ideal? There is already a config.unix.h.in, and code in the CMakeLists.txt to handle macOS / Linux builds. (Admittedly, it may need a little bit of tweaking for Linux, although a while ago I tested it on Ubuntu.)

Also, using vcpkg_configure_make builds for macOS (at least) is going to be problematic, as the gettext runtime's native configure / build scripts do various undesirable things, like trigger a messagebox to install a Java runtime (even if --disable-java is specified - this may depend on the version of macOS). I'd strongly encourage sticking with the current CMakeLists.txt setup for the port for macOS.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Mar 5, 2020

@past-due Infact, if you need to use gettext in Linux and OSX, it is actually installed using apt / yum / brew instead of using gettext in vcpkg.
See code here:

So that's why I create this PR.

@past-due
Copy link
Contributor

past-due commented Mar 5, 2020

@JackBoosY: Ah, to clarify: A little while back, I tested the gettext port with that

if(VCPKG_TARGET_IS_LINUX)
    set(VCPKG_POLICY_EMPTY_PACKAGE enabled)
    ...
    return()

block removed / commented-out, and it built on Ubuntu.

For reference: #4849

Also that block does not apply to macOS builds, which use the config.unix.h.in and logic in the CMakeLists.txt today. (I use these quite frequently, and actually fixed those macOS builds back in #4849.)

Have you tried simply commenting out the VCPKG_POLICY_EMPTY_PACKAGE block that applies to Linux? It's possible something broke since #4849, but it was working with the CMake build setup in that case.

@JackBoosY
Copy link
Contributor Author

@past-due I will have a try, thanks for the info.

@JackBoosY JackBoosY changed the title [gettext]Support UNIX instead of apt-get [gettext]Support Linux and OSX build Mar 11, 2020
@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Jul 1, 2020
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@JackBoosY JackBoosY marked this pull request as ready for review September 8, 2020 08:08
@JackBoosY JackBoosY marked this pull request as draft September 8, 2020 08:08
@JackBoosY
Copy link
Contributor Author

Replaced by #11776

@JackBoosY JackBoosY closed this Sep 15, 2020
@JackBoosY JackBoosY deleted the dev/jack/gettext_support_linux branch September 15, 2020 09:09
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gettext] msgfmt (and other gettext bin tools) missing on macOS & Windows
5 participants