Generate consistent metadata view assembly names #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 76.14% 76.17% +0.02%
==========================================
Files 110 110
Lines 7185 7194 +9
==========================================
+ Hits 5471 5480 +9
Misses 1714 1714
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
davkean
force-pushed
the
dev/davkean/ConsistentName
branch
2 times, most recently
from
d7046ed
to
4500138
Compare
AArnott
requested changes
Jul 1, 2022
src/Microsoft.VisualStudio.Composition/Configuration/MetadataViewGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.Composition/Configuration/MetadataViewGenerator.cs
Outdated
Show resolved
Hide resolved
Investigating diffs in assembly loads and JIT time is difficult between builds of VS because the proxy assembly that contains the metadata views gets a new name every launch. Consistently generate the names - so that the as long as the same assemblies are involved, the same name is generated.
davkean
force-pushed
the
dev/davkean/ConsistentName
branch
from
4500138
to
6986215
Compare
|
@AArnott Can I have another review on this? |
AArnott
approved these changes
Aug 3, 2022
|
@AArnott thanks! |
|
This should show up in VS on Thursday (since it missed the cut-off for tonight's build and insertion). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating diffs in assembly loads and JIT time is difficult between builds of VS because the proxy assembly that contains the metadata views gets a new name every launch.
Consistently generate the names - so that the as long as the same assemblies are involved, the same name is generated.
This is an identical change I've made to ServiceBroker RPC proxies.
(I've not actually tested this - as I cannot get MEF building at the moment on my box)