Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package restore in init.ps1 #1

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Fix package restore in init.ps1 #1

merged 1 commit into from
Oct 15, 2016

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Oct 15, 2016

When restoring packages for a project.json directly, as init.ps1 will do for nuproj projects, the config file is not automatically found by nuget.exe. This forces it to consider that, which lets the package restore succeed since the packages come from sources other than nuget.org.

@msftclas
Copy link

Hi @AArnott, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andrew Arnott). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Contributor

@IlyaBiryukov IlyaBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@IlyaBiryukov IlyaBiryukov merged commit b958bb4 into master Oct 15, 2016
@AArnott AArnott deleted the dev/andarno/oss branch October 15, 2016 06:14
@AArnott
Copy link
Member Author

AArnott commented Oct 15, 2016

Thanks.

AArnott referenced this pull request in AArnott/vs-streamjsonrpc Oct 29, 2020
This was allocating 8012 objects in a perf trace I took (the #1 most allocated object). It should have been 0.
AArnott referenced this pull request in AArnott/vs-streamjsonrpc Oct 29, 2020
This was allocating 8012 objects in a perf trace I took (the #1 most allocated object). It should have been 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants