Be more liberal with the accepted type for a message id #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers do not strictly follow the JSON-RPC spec and stringify the id, even if the client sent it as a number.
|
De minimis PRs like this are fine. And thanks for filing the bug against the other server. Your justification for this change seems reasonable. We just need to add a test to https://github.com/microsoft/vs-streamjsonrpc/blob/master/src/StreamJsonRpc.Tests/JsonRpcClient20InteropTests.cs |
|
|
AArnott
approved these changes
Jun 10, 2019
AArnott
pushed a commit
that referenced
this pull request
Oct 30, 2024
Bumps [xunit](https://github.com/xunit/xunit) from 2.9.1 to 2.9.2. - [Commits](xunit/xunit@v2-2.9.1...v2-2.9.2) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers do not strictly follow the JSON-RPC spec and stringify the
id, even if the client sent it as a number.
Note: We've already filed a bug against the service that stringifies all ids but we're not expecting a fix from them soon.
PS: I know you are not accepting pull requests yet but wanted to get this on your radar.