Add option to deserialize the original exception types thrown by the RPC server #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
- Coverage 90.00% 89.91% -0.09%
==========================================
Files 54 54
Lines 4470 4481 +11
==========================================
+ Hits 4023 4029 +6
- Misses 447 452 +5
Continue to review full report at Codecov.
|
Populate RemoteInvocationException.DeserializedErrorData with CommonErrorData even when we have the InnerException. This lets existing JsonRpc users switch to ISerializable without breaking any existing code.
ankitvarmait
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already possible in v2.6 thanks to #505, but it required overriding virtual methods to take advantage of. Now it's as easy as setting a property on the
JsonRpcinstance.Closes #468