Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading Newtonsoft.Json in MessagePack scenarios #583

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Oct 19, 2020

The only dependency was our camelCase conversion.

This avoids an assembly load, which is independently valuable. But it is also a prereq to fixing #576.

The only dependency was our camelCase conversion.
@AArnott AArnott added this to the v2.7 milestone Oct 19, 2020
@AArnott AArnott self-assigned this Oct 19, 2020
@AArnott AArnott requested review from tmat and milopezc October 19, 2020 17:53
@AArnott
Copy link
Member Author

AArnott commented Oct 19, 2020

Since PR builds don't trigger (AzDO bug), here is the manually triggered PR build.

@codecov-io
Copy link

Codecov Report

Merging #583 into master will decrease coverage by 0.09%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   90.02%   89.92%   -0.10%     
==========================================
  Files          54       54              
  Lines        4481     4487       +6     
==========================================
+ Hits         4034     4035       +1     
- Misses        447      452       +5     
Impacted Files Coverage Δ
src/StreamJsonRpc/Utilities.cs 93.75% <83.33%> (-6.25%) ⬇️
src/StreamJsonRpc/CommonMethodNameTransforms.cs 100.00% <100.00%> (ø)
src/StreamJsonRpc/JsonRpc.cs 92.85% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebec99...e0dc2a9. Read the comment docs.

@AArnott AArnott merged commit 5d6e691 into microsoft:master Oct 19, 2020
@AArnott AArnott deleted the localCamelCase branch October 19, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants