Fix possible data corruption from deserializing error details twice #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MessagePackFormatter would deserialize error details twice. The first happened with a live buffer. The second one happened sometime later, concurrently with another thread that is clearing/recycling the buffer. This led to non-deterministic behavior including returning null as the error details but could also lead to reading corrupted data due to use of a recycled buffer. Fixes microsoft#585
milopezc
approved these changes
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 86.44% 89.92% +3.48%
==========================================
Files 40 54 +14
Lines 3084 4488 +1404
Branches 593 0 -593
==========================================
+ Hits 2666 4036 +1370
- Misses 302 452 +150
+ Partials 116 0 -116
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MessagePackFormatter would deserialize error details twice. The first happened with a live buffer. The second one happened sometime later, concurrently with another thread that is clearing/recycling the buffer. This led to non-deterministic behavior including returning null as the error details but could also lead to reading corrupted data due to use of a recycled buffer.
Fixes #585