Add support for activity tracing #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 89.89% 90.22% +0.32%
==========================================
Files 55 59 +4
Lines 4630 4868 +238
==========================================
+ Hits 4162 4392 +230
- Misses 468 476 +8
Continue to review full report at Codecov.
|
kelltrick
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
It all looks good, I left a few nits. The only thing I feel strongly about is that we should allow uppercase inbound hex simply because A. the standard says implementers must accept upper case hex and B. the reverse hex decoding array you have defined already to accommodates uppercase letters.
ankitvarmait
approved these changes
Nov 8, 2020
AArnott
force-pushed
the
trace-context
branch
from
5fbebac to
910ce9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
traceparentandtracestateproperties to JSON-RPC request messages to carry an activity across the wire for end-to-end activity tracing.This allows a set of structured log files to be aggregated with a viewer like Microsoft's Service Trace Viewer to produce a cross process/machine view like this (where the green boxes are from the RPC client and the yellow boxes are from the RPC server):
There are a variety of other views this tool offers. The
ActivityTracing_IntegrationTesttest produces the log files that led to the above screenshot.Closes #470