Omit line info handling #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David Kean reports this costs us 20MB of memory.
davkean
approved these changes
May 21, 2021
javierdlg
approved these changes
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 90.28% 90.30% +0.01%
==========================================
Files 59 59
Lines 4940 4950 +10
==========================================
+ Hits 4460 4470 +10
Misses 480 480
Continue to review full report at Codecov.
|
|
This is from a trace during solution open of 468 projects:
168 projects looks about the same, so looks like a fixed overhead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davkean reports this costs us 20MB of memory.