Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.1 instead of netcoreapp3.1 #698

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 31, 2021

This should theoretically promote proper running on mono, which implements netstandard2.1. It maintains support for netcoreapp3.1 (netcoreapp2.1, actually).

@AArnott AArnott added this to the v2.9 milestone Aug 31, 2021
@AArnott AArnott requested a review from BertanAygun August 31, 2021 17:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #698 (2ee0ecd) into main (1c3f264) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   89.95%   89.96%           
=======================================
  Files          60       60           
  Lines        5158     5162    +4     
=======================================
+ Hits         4640     4644    +4     
  Misses        518      518           
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 91.86% <ø> (ø)
src/StreamJsonRpc/MessagePackFormatter.cs 92.55% <ø> (ø)
src/StreamJsonRpc/RequestId.cs 68.96% <ø> (ø)
src/StreamJsonRpc/WebSocketMessageHandler.cs 76.56% <ø> (+1.56%) ⬆️
src/StreamJsonRpc/Reflection/RpcTargetInfo.cs 92.01% <0.00%> (-0.77%) ⬇️
src/StreamJsonRpc/MessageHandlerBase.cs 96.38% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3f264...2ee0ecd. Read the comment docs.

This should theoretically promote proper running on mono, which implements netstandard2.1. It maintains support for netcoreapp3.1 (netcoreapp2.1, actually).
@AArnott AArnott force-pushed the TargetNetStandard2.1 branch from 05caa9c to 2ee0ecd Compare August 31, 2021 18:19
@AArnott AArnott merged commit c5abe51 into microsoft:main Aug 31, 2021
@AArnott AArnott deleted the TargetNetStandard2.1 branch August 31, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants