Add ClientRequiresNamedArguments option for IProgress<T> notifications
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An individual method or entire RPC target object may have this new option applied to get named arguments syntax used for callbacks (e.g. `IProgress<T>.Report` notifications). This is useful for when the RPC client is LSP, which requires named arguments in the `$/progress` notification.
AArnott
changed the title
ClientRequiresNamedArguments optionClientRequiresNamedArguments option for IProgress<T> notifications
milopezc
approved these changes
Nov 4, 2021
dibarbet
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An individual method or entire RPC target object may have this new option applied to get named arguments syntax used for callbacks (e.g.
IProgress<T>.Reportnotifications).This is useful for when the RPC client is LSP, which requires named arguments in the
$/progressnotification.An LSP server that wishes to opt into this new behavior should add the RPC target option with an additional option:
rpc.AddLocalRpcTarget( this.server, new JsonRpcTargetOptions { UseSingleObjectParameterDeserialization = true, + ClientRequiresNamedArguments = true, })