Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonRpcIgnoreAttribute to block RPC access to particular methods #758

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jan 21, 2022

No description provided.

@AArnott AArnott added this to the v2.11 milestone Jan 21, 2022
@AArnott AArnott enabled auto-merge January 21, 2022 16:43
@codecov-commenter
Copy link

Codecov Report

Merging #758 (699d3be) into main (9b9bc4d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   91.67%   91.73%   +0.06%     
==========================================
  Files          61       61              
  Lines        5307     5324      +17     
==========================================
+ Hits         4865     4884      +19     
+ Misses        442      440       -2     
Impacted Files Coverage Δ
src/StreamJsonRpc/Reflection/RpcTargetInfo.cs 93.28% <100.00%> (+1.15%) ⬆️
src/StreamJsonRpc/Resources.Designer.cs 67.50% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9bc4d...699d3be. Read the comment docs.

@AArnott AArnott merged commit 3df6305 into microsoft:main Jan 21, 2022
@AArnott AArnott deleted the JsonRpcIgnore branch January 21, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants