Add RPC marshaling support for custom interfaces #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteo-prosperi
commented
Mar 7, 2022
matteo-prosperi
commented
Mar 7, 2022
matteo-prosperi
commented
Mar 7, 2022
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
matteo-prosperi
commented
Mar 7, 2022
AArnott
requested changes
Mar 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 91.69% 91.87% +0.17%
==========================================
Files 61 61
Lines 5323 5342 +19
==========================================
+ Hits 4881 4908 +27
+ Misses 442 434 -8
Continue to review full report at Codecov.
|
matteo-prosperi
commented
Mar 8, 2022
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
matteo-prosperi
force-pushed
the
dev/maprospe/marshalable
branch
2 times, most recently
from
8ab5d80 to
3570d33
Compare
matteo-prosperi
force-pushed
the
dev/maprospe/marshalable
branch
from
3570d33 to
fa1f68d
Compare
BertanAygun
reviewed
Mar 10, 2022
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Show resolved
Hide resolved
matteo-prosperi
commented
Mar 10, 2022
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Show resolved
Hide resolved
matteo-prosperi
commented
Mar 10, 2022
AArnott
changed the title
AArnott
reviewed
Mar 11, 2022
AArnott
reviewed
Mar 11, 2022
AArnott
approved these changes
Mar 18, 2022
added 2 commits
March 18, 2022 13:38
…ft/vs-streamjsonrpc into dev/maprospe/marshalable
matteo-prosperi
added a commit
that referenced
this pull request
Mar 22, 2022
…ng capabilities (#783) Addressing failures similar to ``` StreamJsonRpc.RemoteMethodNotFoundException : Unable to find method 'xxx' on {no object} for the following reasons: Deserializing JSON-RPC argument with name "observer" and position 1 to type "xxx" failed: Could not create an instance of type xxx. Type is an interface or abstract class and cannot be instantiated. Path 'params[1].__jsonrpc_marshaled'. ``` when calling APIs under the following conditions: - using Newtonsoft.Json - the API has marshalable (`IObserver<>`, `IDisposable` or interfaces with `RpcMarshalableAttribute`) objects as parameters or return values - the user replaces `JsonMessageFormatter`'s `ContractResolver`. This issue has worsened since #777 due to more behavior being delegated to the `ContractResolver` This PR integrates the `ContractResolver` provided by the user with `MarshalContractResolver` before the first serialization or deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #774.
I added the
RpcMarshalableattribute that can be applied to an interface thatIDisposableI added unit tests and docs.