Remove properties inadvertently made public #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in microsoft#908 during the refactoring that created a `FormatterBase` class, properties that used to be explicit interface implementations were made public. These properties are of no interest to the standard user of a formatter so I don't want them exposed publicly. They are still exposed via a public interface so that the advanced cases they were introduced to address are still addressed. This is not a breaking change relative to our last stable release, because the APIs being removed were added only recently.
matteo-prosperi
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #908 during the refactoring that created a
FormatterBaseclass, properties that used to be explicit interface implementations were made public. These properties are of no interest to the standard user of a formatter so I don't want them exposed publicly. They are still exposed via a public interface so that the advanced cases they were introduced to address are still addressed.This is not a breaking change relative to our last stable release, because the APIs being removed were added only recently.