Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NoThrowAwaitable for ValueTask and ValueTask<TResult> #1193

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Implement NoThrowAwaitable for ValueTask and ValueTask<TResult> #1193

merged 2 commits into from
Jun 5, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 5, 2023

No description provided.

AArnott
AArnott requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good. But I don't see a single test that actually demonstrates the recommended usage pattern. Can you add that? Maybe as a [Theory] that takes a bool so that it can exercise the passing or failure path based on the bool value.

AArnott
AArnott approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@AArnott AArnott added this to the v17.7 milestone Jun 5, 2023
@AArnott AArnott enabled auto-merge June 5, 2023 18:46
@AArnott AArnott merged commit 2608987 into microsoft:main Jun 5, 2023
@sharwell sharwell deleted the no-throw-valuetask branch June 6, 2023 13:12
@sharwell sharwell mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v17.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @AArnott