Remove Csharp tests #2632
Merged
Remove Csharp tests #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to verify that this passes CodeQL before merging? If you need to, you can manually run the 1ES pipeline |
|
Yup I can try doing that! |
|
Manually ran the 1ES pipeline on this branch and the CodeQL detected languages are now only Javascript and Python so no more warnings from CodeQL about csharp. |
alexweininger
approved these changes
Apr 17, 2024
|
lmao, hooray for compliance actually reducing our test coverage. . . 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this since our CodeQL snapshots are failing for csharp and we could either remove the files, add a build task, or create a seperate non-production repo in order to be compliant. After discussion we decided to just remove the tests.