Remove database connection logic and view #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
approved these changes
Jul 11, 2024
nturinski
added a commit
that referenced
this pull request
Aug 23, 2024
This reverts commit 97388ac.
nturinski
added a commit
that referenced
this pull request
Aug 23, 2024
This reverts commit efbaf03.
nturinski
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of security initiative, we were looking at dropping the dedicated Azure Databases (Cosmosdb) logic and view. In the future we may be able to add support for a more generalized connection/identity view.
Should we wait until the future identity work is done before stripping this section out, or should we go ahead and remove it now?