Add Dotnet Isolated runtime specific dependencies and cleanup durableUtils
#3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
changed the title
durableUtils
MicroFish91
commented
Feb 28, 2023
src/utils/durableUtils.ts
Outdated
| // Seems that the package arrives out-dated and needs to be updated to at least 2.9.1; | ||
| // otherwise, error appears when running with sql backend | ||
| if (!isDotnetIsolated) { | ||
| packageNames.push(dotnetLtsDfBasePackage); |
There was a problem hiding this comment.
Not 100% sure if this is the best way to handle this; let me know if anyone has opinions on if this should be handled differently.
| @@ -111,19 +113,9 @@ export namespace durableUtils { | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access | |||
| let packageReferences = result?.['Project']?.['ItemGroup']?.[0]?.PackageReference ?? []; | |||
There was a problem hiding this comment.
Unrelated to this PR, but there is a bug here if the package references are split into multiple item groups since we're only using the first item group. I can fix this in a separate PR.
There was a problem hiding this comment.
Ahh good catch! It should probably loop through the 'ItemGroup'[] and check for the 'PackageReference' instead
alexweininger
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .NET Isolated runtime specific dependencies, specifically for
NetheriteandMSSQLstorage types.Partially addresses the error message shown in #3566.