build: Support 1ES pipelines #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Feb 2, 2024
| @@ -0,0 +1,17 @@ | |||
| steps: | |||
| - task: Npm@1 | |||
| displayName: "\U0001F449 Package" | |||
There was a problem hiding this comment.
This is the 👉 emoji. It makes it much easier to visually separate what is from our template vs. what is from 1ES templates.
| customCommand: run package | ||
| condition: succeeded() | ||
|
|
||
| - task: CopyFiles@2 |
There was a problem hiding this comment.
1ES has a publish task built in, you just have to copy the files to the publish folder
MRayermannMSFT
approved these changes
Feb 2, 2024
|
So for clarification, does this mean that we'll stop publishing our @microsoft packages to npm and have to use the 1ES registry or whatever the equivalent is? |
We still plan to publish to NPM, but we have to do release through ESRP instead of via our own accounts / our own bot account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.