Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to option for saying what SiteNameStep is for instead of passing in agent metadata #1694

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Switch to option for saying what SiteNameStep is for instead of passing in agent metadata #1694

merged 2 commits into from
Feb 13, 2024

Conversation

MRayermannMSFT
Copy link
Member

No description provided.

@MRayermannMSFT MRayermannMSFT requested a review from a team as a code owner February 13, 2024 00:16
@MRayermannMSFT MRayermannMSFT mentioned this pull request Feb 13, 2024
Merged
nturinski
nturinski approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, should we be localizing these strings? Any talk about that for copilot?

nturinski
nturinski previously approved these changes Feb 13, 2024
View reviewed changes
@MRayermannMSFT
Copy link
Member Author

Just out of curiosity, should we be localizing these strings? Any talk about that for copilot?

Let's talk about this in person tomorrow. I'm leaning towards:

  • No for anything that is not displayed to user
  • Yes for anything that is displayed to user

I will update this PR as needed tomorrow morning.

@MRayermannMSFT MRayermannMSFT merged commit d99390d into main Feb 13, 2024
9 checks passed
@MRayermannMSFT MRayermannMSFT deleted the dev/mrayermann/switchtooption branch February 13, 2024 21:34
nturinski added a commit that referenced this pull request Mar 8, 2024
@nturinski
Revert "Switch to option for saying what SiteNameStep is for instead …
5e92f9b 
…of passing in agent metadata (#1694)"

This reverts commit d99390d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MRayermannMSFT @nturinski