Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-pipelines: Ignore .vscode-test directory in CG scans #1824

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

bwateratmsft
Copy link
Contributor

We're getting a large number of component governance alerts because certain VSCode built-in extensions (handlebars, npm, json, etc.) have the same package names as NPM packages. The alerts are false on multiple levels--firstly, they're in .vscode-test which should not be scanned, and secondly, they aren't the actual NPM packages--just the package name and version matches a vulnerable NPM package.

This should suppress those CG alerts.

@bwateratmsft bwateratmsft requested a review from a team as a code owner November 25, 2024 16:29
@bwateratmsft bwateratmsft changed the title Ignore .vscode-test directory in CG scans azure-pipelines: Ignore .vscode-test directory in CG scans Nov 25, 2024
@@ -47,6 +47,8 @@ extends:
sdl:
credscan:
suppressionsFile: $(Build.SourcesDirectory)\.azure-pipelines\compliance\CredScanSuppressions.json
componentgovernance:
ignoreDirectories: $(Build.SourcesDirectory)\**\.vscode-test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this **\ syntax will work. If not, we will have to explicitly exclude all of the packages' .vscode-test directories.

@bwateratmsft bwateratmsft merged commit a1a4fa9 into main Nov 25, 2024
4 checks passed
@bwateratmsft bwateratmsft deleted the bmw/cgexclusion branch November 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants