Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy settings support #339

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Drop legacy settings support #339

merged 1 commit into from
Oct 3, 2023

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 3, 2023 •
edited
Loading

Closes #341

@karthiknadig karthiknadig self-assigned this Oct 3, 2023
@karthiknadig karthiknadig added the debt Technical debt or repo cleanup label Oct 3, 2023
@karthiknadig karthiknadig marked this pull request as ready for review October 3, 2023 17:22
@karthiknadig karthiknadig enabled auto-merge (squash) October 3, 2023 17:23
karrtikr
karrtikr approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing issue reference in PR, otherwise LGTM

@karthiknadig karthiknadig merged commit b19ba19 into microsoft:main Oct 3, 2023
@karthiknadig karthiknadig deleted the legacy-config branch October 3, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@paulacamargo25 paulacamargo25 Awaiting requested review from paulacamargo25

Assignees

@karthiknadig karthiknadig

Labels
debt Technical debt or repo cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop legacy settings support
2 participants
@karthiknadig @karrtikr