Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Changing overlay text based on clients #599

Merged
merged 4 commits into from
Feb 14, 2018
Merged

Changing overlay text based on clients #599

merged 4 commits into from
Feb 14, 2018

Conversation

rakatyal
Copy link
Contributor

No description provided.

roblourens
roblourens suggested changes Feb 13, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I don't want to hardcode any more VS checks - could you make this a launch config param instead?

@roblourens
Copy link
Member

And prefix the param with a _ - we will do this for any new "private" launch config params

@rakatyal
Copy link
Contributor Author

@roblourens: Addressed.

@roblourens
Copy link
Member

Please don't add it to the package.json, that's what makes it show up for users in launch.json

@rakatyal
Copy link
Contributor Author

Done. Thanks!

@roblourens roblourens merged commit 02c240f into master Feb 14, 2018
@roblourens roblourens added this to the February 2018 milestone Mar 5, 2018
@sirinartk sirinartk mentioned this pull request Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens requested changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@rakatyal @roblourens