Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting showSystemKits #2520

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Add setting showSystemKits #2520

merged 5 commits into from
Apr 28, 2022

Conversation

bharatvaj
Copy link
Contributor

Allows the user to enable/disable the listing of scanned system
kits.

This change addresses item #1461

This changes visible behavior

Allows the user to enable/disable the listing of scanned system
kits.

Fixes microsoft#1461
@ghost
Copy link

ghost commented Apr 24, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry in the CHANGELOG.md to describe the setting you've added. Follow the format for the existing changes and make sure to give yourself credit. If you have any questions about what to put there, feel free to ask.

package.nls.json Outdated
@@ -122,6 +122,7 @@
"cmake-tools.configuration.cmake.setBuildTypeOnMultiConfig.description": "Set CMAKE_BUILD_TYPE also on multi config generators",
"cmake-tools.configuration.cmake.skipConfigureIfCachePresent.description": "Skip over the configure process if cache is present.",
"cmake-tools.configuration.cmake.cmakeCommunicationMode": "The protocol used to communicate between the extension and CMake",
"cmake-tools.configuration.cmake.showSystemKits.description": "List system kits in kit selection",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change List to Include?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure! Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbrow The changes have been done. Hope they are fine.

@bobbrow bobbrow enabled auto-merge (squash) April 28, 2022 17:31
@bobbrow bobbrow merged commit 4a9dafd into microsoft:main Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants