Normalize the case before comparing compilation database paths (#4207) #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0zmo
force-pushed
the
CompDbPathComparison
branch
from
11d92cc to
74dce13
Compare
|
@microsoft-github-policy-service agree |
gcampbell-msft
previously approved these changes
Dec 10, 2024
gcampbell-msft
approved these changes
Dec 10, 2024
hippo91
pushed a commit
to hippo91/vscode-cmake-tools
that referenced
this pull request
Dec 21, 2024
…soft#4209) Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #4207
This changes
Before comparing the compilation database path with the contents of
cmake.copyCompileCommandsmake sure to platform-normalize the cases of both values.