Skip to content

Commit

Permalink
support yarn pnp for nodeAddonIncludes
Browse files Browse the repository at this point in the history
This solves problems with Yarn PnP and node addon includes.
  • Loading branch information
Mesteery committed Mar 7, 2021
1 parent d2cb685 commit 1330360
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Extension/src/LanguageServer/configurations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,13 @@ export class CppProperties {
if (!error) {
try {
const pathToNode: string = which.sync("node");
const pathToYarn: string = which.sync("yarn");
const nodeAddonMap: { [dependency: string]: string } = {
"nan": `"${pathToNode}" --no-warnings -e "require('nan')"`,
"node-addon-api": `"${pathToNode}" --no-warnings -p "require('node-addon-api').include"`
"node-addon-api": `"${pathToNode}" --no-warnings -p "require('node-addon-api').include"`,
// support Yarn PnP
"nan": `"${pathToYarn} ${pathToNode}" --no-warnings -e "require('nan')"`,
"node-addon-api": `"${pathToYarn} ${pathToNode}" --no-warnings -p "require('node-addon-api').include"`
};

for (const dep in nodeAddonMap) {
Expand Down

0 comments on commit 1330360

Please sign in to comment.