Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppvsdbg] Option to disable thread exit logging in launch.json #1017

Closed
roblourens opened this issue Sep 7, 2017 · 22 comments · Fixed by #5652
Closed

[cppvsdbg] Option to disable thread exit logging in launch.json #1017

roblourens opened this issue Sep 7, 2017 · 22 comments · Fixed by #5652
Labels
debugger fixed Check the Milestone for the release in which the fix is or will be available.
Milestone

Comments

@roblourens
Copy link
Member

From @akbyrd on September 7, 2017 21:20

Desired Behavior:

I'd like the ability to disable thread exit messages in the Debug Console. Options already exist for other types of messages such as module loads (under logging.moduleLoad), so this would simply be another one added to the list.

vscode thread exit messages

  • VSCode Version: Code - Insiders 1.17.0-insider (ac167c41bababe6c47180012723fa2bc52610ff4, 2017-09-07T05:24:04.020Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
python don 0.7.0
Lua key 0.0.9
cpptools ms- 0.12.3
code-settings-sync Sha 2.8.3

Steps to Reproduce:

  1. Launch a C++ program under the debugger
  2. Notice "The thread #### has exited with code 0 (0x0)" messages in the Debug Console

Copied from original issue: microsoft/vscode#33965

@dfdumaresq
Copy link

This would be a huge help for those, like me, who often work on a single laptop screen!

@GoaLitiuM
Copy link

GoaLitiuM commented Aug 27, 2018

This would help everyone, especially if the program you are debugging has tens of threads starting and stopping at times. The option already exists in Visual Studio, so why not in VSCode as well?

@cooper352
Copy link

@GoaLitiuM Where is this option in Visual Studio? I've been trying to disable thread exit messages in the console window, but can only find an option to disable them in the output window.

@akbyrd
Copy link

akbyrd commented Aug 30, 2018

Right clicking in the Output Window is the way I normally get to it:

thread exit

@dfdumaresq
Copy link

Has there been any progress on this for VS Code users?

@dfdumaresq
Copy link

Can you give us an update please?

@sean-mcmanus
Copy link
Contributor

@WardenGnaw ? I don't think any work has been done on this.

@dcarapic
Copy link

I would also really like this. Currently I have a mix of standard console output and bunch of Loaded/thread exited messages which do not provide any value.

@dfdumaresq
Copy link

While we've been waiting for this, searching the VSCode console has improved greatly.
Try clicking in the console and typing (On Mac) CMD-F, then type your search term. Use the arrow keys to jump to next and previous.

@ChronosWS
Copy link

+1, thread exit messages are almost completely useless, especially in ASP.NET Core apps where there are always threads starting and stopping.

@akbyrd
Copy link

akbyrd commented Oct 16, 2019

Issue created 2 years ago. Eesh.

@GoaLitiuM
Copy link

We get a pretty useless "enableDebugHeap" option but not this? Come on...

@ssg
Copy link

ssg commented Nov 20, 2019

We would benefit from this too.

@awarwick
Copy link

This makes it extremely difficult to verify the result of unit tests (note the scrollbar on the right):

Image

Thread exit messages are not helpful in most cases. Can we please get an option to disable them?

@GoaLitiuM
Copy link

I don't understand why this has not been implemented yet. The debugging engine is the same used by Visual Studio, so this should be a trivial fix of just exposing the option to VSCode extension.

@GoaLitiuM
Copy link

Latest extension (0.28.0) does not seem to print any thread exit message anymore 👍, yet there was no new logging options added or any mentions about this in changelogs.

@GoaLitiuM
Copy link

Update 0.28.1 brought back the thread exit messages... Can we please have the option to disable these?

@WardenGnaw WardenGnaw changed the title Option to disable thread exit logging in launch.json [cppvsdbg] Option to disable thread exit logging in launch.json Jun 19, 2020
@WardenGnaw WardenGnaw linked a pull request Jun 19, 2020 that will close this issue
@WardenGnaw
Copy link
Member

Most of the comments and images indicate the issue is the threadExit messages are from debugger type cppvsdbg.

Add the following to your launch.json to remove those messages:

"logging": {
   "threadExit": true
}

If you are looking to disable threadEvents from GDB, see #5660

@dfdumaresq
Copy link

dfdumaresq commented Jun 19, 2020

I'm seeing this in Microsoft .NET Core Debugger (vsdbg). Have I logged the issue in the wrong repo?

The fix above does not work for me.

[Information] 20:08:11 Microsoft.AspNetCore.Hosting.Internal.WebHost Request finished in 35.6332ms 200 image/jpeg
The thread 203181 has exited with code 0 (0x0).
The thread 202213 has exited with code 0 (0x0).
The thread 203288 has exited with code 0 (0x0).
The thread 203922 has exited with code 0 (0x0).
The thread 203171 has exited with code 0 (0x0).
The thread 203169 has exited with code 0 (0x0).
The thread 203306 has exited with code 0 (0x0).
The thread 203578 has exited with code 0 (0x0).
The thread 203579 has exited with code 0 (0x0).
The thread 202296 has exited with code 0 (0x0).

@sean-mcmanus sean-mcmanus added this to the 0.29.0 milestone Jun 20, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 20, 2020
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jun 20, 2020

@dfdumaresq The fix hasn't been shipped yet. It's planned for 0.29.0-insiders for the C/C++ extension (not sure how that relates to the .NET Core debugger). @WardenGnaw probably know.

@WardenGnaw
Copy link
Member

@dfdumaresq You will want to see the options in logging for the VS Code Omnisharp C# extension. Heres is the schema: https://github.com/OmniSharp/omnisharp-vscode/blob/aa85edeace0abd981c0c468c4c323dcd6faf60aa/package.json#L450

@dfdumaresq
Copy link

dfdumaresq commented Jun 23, 2020

Thanks @sean-mcmanus and @WardenGnaw for the above link to logging options.

Just a comment as an enduser: it would be more helpful if all the descriptions for logging options included a sentence saying what the default is, like the threadExit and processExit do.
Right now, it's not consistent and I have a bunch that were set to defaults, unbeknownst to me.

asialasr pushed a commit to asialasr/vscode-cpptools that referenced this issue Mar 12, 2021
…nd Telemetry (microsoft#1017)

In the Container Picker Dialog, it uses Name and ShortId. However, if
Id is null, ShortId tries to get the length of the Id and this causes a
NullRefException.

We also are adding null containers for GetRemoteDockerContainers. Added
a null check. 

Adding a null check on Id so it just returns null.

Added support for logging errors to the output window.

Added telemetry to count for errors in Docker process listings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger fixed Check the Milestone for the release in which the fix is or will be available.
Projects
None yet
Development

Successfully merging a pull request may close this issue.