Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new input verification of configurations.intelliSenseMode fails to verify msvc-x{86|64} if configurations.compilerPath contains a variable #4141

Closed
mistersandman opened this issue Aug 26, 2019 · 1 comment
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. regression A bug that didn't exist in a previous release
Milestone

Comments

@mistersandman
Copy link
Contributor

Type: LanguageService

Describe the bug

  • OS and Version: Windows (any version)
  • VS Code Version: any
  • C/C++ Extension Version: 0.25.0
  • Other extensions you installed (and if the issue persists after disabling them): none
  • A clear and concise description of what the bug is.

To Reproduce
Example configuration in c_cpp_properties.json triggering the issue:

{
    "env": {
        "vc.path": "<path_to_your_msvc_installation>",
        ...
    },
    "configurations": [
        {
            ...,
            "compilerPath": "${vc.path}\\bin\\HostX64\\x64\\cl.exe",
            "intelliSenseMode": "msvc-x64",
            ...
        }
    ]
}

Problems reported for the above configuration: intelliSenseMode msvc-x64 is incompatible with compilerPath.

Expected behavior
No problems reported, as the expanded compilerPath is a valid compiler for msvc-x64 mode.

Additional context
In function isCompilerIntelliSenseModeCompatible, util.extractCompilerPathAndArgs is called with the unexpanded compiler path, which only expects expanded paths.

let compilerPathAndArgs: util.CompilerPathAndArgs = util.extractCompilerPathAndArgs(configuration.compilerPath);

mistersandman pushed a commit to mistersandman/vscode-cpptools that referenced this issue Aug 26, 2019
@sean-mcmanus sean-mcmanus added bug Feature: Configuration An issue related to configuring the extension or IntelliSense regression A bug that didn't exist in a previous release labels Aug 26, 2019
@sean-mcmanus sean-mcmanus added this to the 0.25.1 milestone Aug 26, 2019
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 26, 2019
@sean-mcmanus
Copy link
Collaborator

The fix is available in 0.25.1 now.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. regression A bug that didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

2 participants