Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppvsdbg Debugging becomes no-op between 1.4.1 and 1.5.0 #7808

Closed
hostilefork opened this issue Jul 9, 2021 · 17 comments
Closed

cppvsdbg Debugging becomes no-op between 1.4.1 and 1.5.0 #7808

hostilefork opened this issue Jul 9, 2021 · 17 comments
Assignees
Labels
bug debugger fixed Check the Milestone for the release in which the fix is or will be available. regression A bug that didn't exist in a previous release
Milestone

Comments

@hostilefork
Copy link

hostilefork commented Jul 9, 2021

Bug type: Debugger

  • OS and Version: Windows 10
  • VS Code Version: 1.58.0
  • C/C++ Extension Version: 1.5.0

After an automated upgrade to the C++ extension today from 1.4.1 to 1.5.0, if I request to run with debugging shows no output in any of the logs (Terminal, Debug Console, Output).

I added "logging": {"engineLogging": true} to launch.json, but this provided no output.

I tried downgrading from 1.5.0 to 1.4.1. That made it work. Also, in 1.4.1 the debug console honored the engineLogging switch I'd added and has a lot of output (along the lines of <- (E) {"seq":3,"type":"event","event":"output","body"). I'll reiterate that no such output was produced after the 1.5.0 upgrade.

From the console, I tried running the file at:

%userprofile%\.vscode\extensions\ms-vscode.cpptools-1.5.0\debugAdapters\vsdbg\bin\vsdbg.exe

When I do this in 1.5.0 I get "FATAL ERROR: Failed to initialize dispatcher with error 8ede0007".

Running the vsdbg.exe from the downgraded ms-vscode.cpptools-1.4.1 directory, I do not get an error. It just sits there, which is presumably the right thing for it to do.

So I'd guess that FATAL ERROR probably has something to do with the problem.

@zeroxia
Copy link

zeroxia commented Jul 9, 2021

Today cpptools prompts an update, and after it, pressing F5 just triggers cmake building, after building success, nothing happens.

(I use cpptools, clangd and cmake-tools)

And I can confirm it's the same as OP, running vsdbg.exe returns immediately error:

FATAL ERROR: Failed to initialize dispatcher with error 8ede0007

I found another computer with cpptools 1.4.1, running vsdbg.exe directly will not prompt any error, just stay there.


Temporary fix:

  1. In VS Code extension side bar, uninstall 1.5.0
  2. configure your user settings to disable auto-update, you can keep auto update check:
    "extensions.autoUpdate": false,
    "extensions.autoCheckUpdates": true, // Actually just remove it, default is true.
    
  3. Download 1.4.1 here: https://github.com/microsoft/vscode-cpptools/releases/tag/1.4.1
  4. Install 1.4.1 and restart editor, everything is back to normal.

@hostilefork
Copy link
Author

hostilefork commented Jul 9, 2021

I actually discovered there seems to be an official method to go back on the extensions. Someone should update the page I found as the top hit for "downgrade visual studio extensions"!!

You can simply click the settings gear on the extension in the list and choose "Install Another Version".

(Note: It seems to update automatically even though I'd requested to go back! But it will last until restart, and at least I don't have to download the VSIX manually. :-/ Getting rid of the auto-update checks seems prudent, because these interruptions at random inopportune moments during development are very, very annoying.)

@hostilefork hostilefork changed the title cppvsdbg Debugging becomes no-op between 1.4.0 and 1.5.0 cppvsdbg Debugging becomes no-op between 1.4.1 and 1.5.0 Jul 9, 2021
@johndhzd
Copy link

johndhzd commented Jul 9, 2021

Same here, No output, No log, Nothing, just UI changed... Downgrade to 1.41 works as before.

@JoeyRxy
Copy link

JoeyRxy commented Jul 9, 2021

Same situation. Use 1.4.1 now. Please fix this.

@sean-mcmanus sean-mcmanus pinned this issue Jul 9, 2021
@sean-mcmanus sean-mcmanus added bug debugger regression A bug that didn't exist in a previous release labels Jul 9, 2021
@sean-mcmanus
Copy link
Collaborator

Sorry about that -- we probably should have shipped the new debuggers in an insiders release instead of putting it directly into 1.5.0.

Is everyone on x86 or x64 machines? Is anyone on an arm64 machine?

@sean-mcmanus sean-mcmanus added the To Verify - Internal To verify if issue reproduces label Jul 9, 2021
@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jul 9, 2021

Hmm...I'm not able to repro any bug. Multiple people tested Windows debugging on multiple machine configurations. @WardenGnaw Any ideas how to repro this?

Can someone check if this repros with https://github.com/microsoft/vscode-cpptools/releases/tag/1.5.0-insiders3 or not? That would help confirm if the change is with the most recent Windows vsdbg update or the newer one introduced in 1.5.0-insiders 24 days ago and we just didn't get any reports of this.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jul 9, 2021

@WardenGnaw Should we just ship a 1.5.1 with the previous Windows x86/x64 debugger or is this easy to fix? Sounds like 1.5.0-insiders3 doesn't repro the bug, so we could publish that version of the debugger and use that for 1.5.1 (instead of the one from 1.4.1)

@zeroxia
Copy link

zeroxia commented Jul 9, 2021

Hmm...I'm not able to repro any bug. Multiple people tested Windows debugging on multiple machine configurations. @WardenGnaw Any ideas how to repro this?

Can someone check if this repros with https://github.com/microsoft/vscode-cpptools/releases/tag/1.5.0-insiders3 or not? That would help confirm if the change is with the most recent Windows vsdbg update or the newer one introduced in 1.5.0-insiders 24 days ago and we just didn't get any reports of this.

I downloaded this 1.5.0-insiders3 .vsix and installed it to test with my previous version 1.4.1 workspace, F5 debugging is running, unlike 1.5.0, nothing happens.

My system is Windows 10 x64. build 19043.

@sean-mcmanus
Copy link
Collaborator

@zeroxia Are you saying 1.5.0-insiders3 doesn't repro the bug?

@hostilefork
Copy link
Author

hostilefork commented Jul 9, 2021

1.5.0-insiders3 does not repro the problem for me.

The MSVC I am using is from Visual Studio Community 2019, Version 16.10.3
on Windows 10 x64, Build 19042.1083

@zeroxia
Copy link

zeroxia commented Jul 9, 2021

@zeroxia Are you saying 1.5.0-insiders3 doesn't repro the bug?

Correct. I can use 1.5.0-insiders3 just like 1.4.1. Debug session can launch, and break point hit, and I can step code execution.

But with 1.5.0 which auto-updated earlier today, when I hit F5, after cmake-tools reporting build successful, nothing happens, no debug session started at all.

@sean-mcmanus sean-mcmanus added this to the 1.5.1 milestone Jul 9, 2021
@mempler
Copy link

mempler commented Jul 9, 2021

Can confirm 1.5.0-insiders3 & 1.4.1 works perfectly fine while 1.5.0 does not.

@sean-mcmanus
Copy link
Collaborator

Thanks for the info everyone -- it sounds like @WardenGnaw has found the cause.

@mcakircali
Copy link

same problem with 1.5.0 update, unable to launch debugger without any error messages. 1.4.1 works...

WardenGnaw added a commit to WardenGnaw/vscode-cpptools that referenced this issue Jul 9, 2021
sean-mcmanus pushed a commit that referenced this issue Jul 9, 2021
* Fix vsdbg crash on windows x64

Addresses #7808

* Update package version and add CHANGELOG
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 9, 2021
@sean-mcmanus
Copy link
Collaborator

Fixed with 1.5.1 (https://github.com/microsoft/vscode-cpptools/releases/tag/1.5.1)

@Archiatrus
Copy link

Archiatrus commented Aug 3, 2021

Fixed with 1.5.1 (https://github.com/microsoft/vscode-cpptools/releases/tag/1.5.1)

Unfortunately, not for me. Debugging stops after a split second without any message. Downgrade to 1.4.1 fixes the problem. I did not try 1.5.0.

Bug type: Debugger

OS and Version: Ubuntu 18.04 (vs code about says Linux x64 4.15.0-151-generic snap)
VS Code Version: 1.58.2
C/C++ Extension Version: 1.5.1

@Archiatrus
Copy link

Retried it again today with VS Code Version 1.59.0 and still C/C++ Extension Version: 1.5.1 and now debugging works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug debugger fixed Check the Milestone for the release in which the fix is or will be available. regression A bug that didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

9 participants