Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mitigation to migrate Insiders users #8704

Closed
Colengms opened this issue Jan 20, 2022 · 1 comment
Closed

Implement mitigation to migrate Insiders users #8704

Colengms opened this issue Jan 20, 2022 · 1 comment
Assignees
@Colengms
Labels
fixed Check the Milestone for the release in which the fix is or will be available. internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Milestone
1.8.0-insiders3 (...

Comments

@Colengms
Copy link
Contributor

The following issue will cause some users who were Insiders to not be migrated to the new Prerelease system correctly: microsoft/vscode#140949 This issue repro'ed for users who got updated to 1.8.0 (insiders3) via the updateChannel mechanism. (Due to the extension programmatically installing the new VSIX).

Once the VS Code issue is fixed, we should ship a release version with additional code to migrate users to the Prerelease system if their updateChannel was set to Insiders or if running a VS Code Insiders build and the updateChannel was unset (default would have been to use cpptools Insiders).
@Colengms Colengms self-assigned this Jan 20, 2022
@Colengms Colengms added this to the 1.8.x milestone Jan 20, 2022
@Colengms Colengms added internal Used to opt-out an issue from having GitHub actions applied to it Language Service labels Jan 20, 2022
@Colengms
Copy link
Contributor Author

This should use a persistent var to avoid migrating the user more than once. If the user manually switches from Prerelease to Release version, we don't want to keep moving them back to Prerelease.

@Colengms Colengms mentioned this issue Jan 20, 2022
Merged
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Colengms Colengms

Labels
fixed Check the Milestone for the release in which the fix is or will be available. internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Projects
None yet
Milestone
1.8.0-insiders3 (1.8.0)
Development

No branches or pull requests
2 participants
@sean-mcmanus @Colengms