Mitigate issue with migrating Insiders to Prerelease #8705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Jan 20, 2022
sean-mcmanus
approved these changes
Jan 20, 2022
|
You might want to get another person to review this too. |
bobbrow
reviewed
Jan 20, 2022
bobbrow
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #8704
This works around microsoft/vscode#140949
When existing VS Code Insiders users were updated to 1.8.0 (insiders3) via the
updateChannelmechanism, the VSIX programmatically downloaded from GitHub was not correctly identified as a Prerelease. Presumably, this means those users were not subscribed to receive further Prerelease versions.This mitigation should take effect once those users receive a release version from the marketplace. If running VS Code Insiders and
updateChannelhad not been modified, they will be subscribed to Prereleases. This only occurs once, to avoid repeatedly moving the user to Prerelease in case they had manually switched to Release.