Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Generate Doxygen Comment from context menu if intelliSenseEngine is "disabled" #10007

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

sean-mcmanus
Copy link
Collaborator

No description provided.

@sean-mcmanus sean-mcmanus requested a review from a team October 14, 2022 17:21
Copy link
Collaborator

@Colengms Colengms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file is applicable, the extension should already be activated or in the process of activating. Internally, they should be waiting for the language client to be ready (i.e. notifyWhenLanguageClientReady), IF needed. If the client is not activated yet, checks that rely on it (i.e. config.C_Cpp.intelliSenseEngine == 'Default') should fail, so inapplicable items should not be getting displayed. If there is an issue here with commands not running when run too early, or being enabled when they should not, that would be a bug. I don't think we should removing things from the menu to avoid investigating and fixing that.

I see no reason we should be hiding anything from the menu. Commands cause activation. If it were not the intention to invoke commands prior to being activated, commands would not cause activation.

@sean-mcmanus
Copy link
Collaborator Author

Sure, I can change it to just check the intelliSenseEngine setting.

@sean-mcmanus sean-mcmanus changed the title Disable context menu options until they're usable. Disable Generate Doxygen Comment from context menu if intelliSenseEngine is "disabled" Oct 14, 2022
@sean-mcmanus sean-mcmanus requested a review from a team October 14, 2022 19:24
@sean-mcmanus sean-mcmanus merged commit 6542b63 into main Oct 14, 2022
@sean-mcmanus sean-mcmanus deleted the seanmcm/disableMenusTillReady branch October 14, 2022 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants