Dispose of cached browse config on dispose if no longer registered. #10608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally intended as an optimization for a race condition at start-up. If a custom configuration provider had previously been used, but had not yet registered, we were clearing out its headers from the database before shortly thereafter needing to add them back in again once it's registered. We addressed this by caching the browse configuration for the provider and using it immediately on the next launch.
This change removes the cache at the end of the session, if the configuration provider did not actually register at all. This avoids a potential security issue, due to execution of a no-longer-desired compilerPath to query for system include paths.