add support for custom variables #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
commented
May 3, 2018
| @@ -107,6 +107,14 @@ | |||
| } | |||
| } | |||
| }, | |||
| "variables" : { | |||
There was a problem hiding this comment.
I debated between "environment" and "variables", but I'm open to suggestions on what to call this. Visual Studio's CppProperties.json has an array called "environments" (yes, plural) that lets you do fancy namespacing, but i don't think we want that.
There was a problem hiding this comment.
launch.json and tasks.json use "env", so I'm thinking maybe we'll go with that to be consistent.
sean-mcmanus
approved these changes
May 3, 2018
…de-cpptools into bobbrow/variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.