Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-pass environment variable resolution #2322

Merged
merged 11 commits into from
Jul 24, 2018
Merged

Add multi-pass environment variable resolution #2322

merged 11 commits into from
Jul 24, 2018

Commits on Jul 24, 2018

  1. fix unit test launch.json target 

    We were passing the root of the test folder instead of the unitTests
specific folder into the runner, so it wasn't finding unit tests.
    John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    5e79538 View commit details
    Browse the repository at this point in the history

  2. fix res. of vars with env,config,workspaceFolder 

    If a variable had env, config, or workspaceFolder as substring, it was
being treated as an environment variable lookup on the reminder of the
string minus the character immediately following the substring. For
instance: envRoot was being looked up as "oot" in the configuarion
environment block.

The issue is that the regex to match the env., config., and
workspaceFolder. patterns used . instead of \.
    John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    5ff8006 View commit details
    Browse the repository at this point in the history

  3. tests existing tag resolution functionality

    @john-patterson
    john-patterson authored and John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    8736bb8 View commit details
    Browse the repository at this point in the history

  4. rough draft

    @john-patterson
    john-patterson authored and John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    419afd0 View commit details
    Browse the repository at this point in the history

  5. refactors common test file 

    This gets rid of linting errors and adopts a more BDD literate assert style.
    @john-patterson
    john-patterson authored and John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    012e2df View commit details
    Browse the repository at this point in the history

  6. fixes linting errors in common.ts

    @john-patterson
    john-patterson authored and John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    91e4dcf View commit details
    Browse the repository at this point in the history

  7. refactors resolveVariables implementation

    John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    06ad729 View commit details
    Browse the repository at this point in the history

  8. adds specific test for user scenario

    John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    6568cef View commit details
    Browse the repository at this point in the history

  9. fix cycle detection and half open detection

    John Patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    d220d5d View commit details
    Browse the repository at this point in the history

  10. simplifies parsing into single pass

    @john-patterson
    john-patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    735c1f3 View commit details
    Browse the repository at this point in the history

  11. fixes Travis CI failing unitTests 

    As per microsoft/vscode-wordcount#5, running tests from CLI isn't supported with vscode except through the [workaround listed for Travis CI](https://code.visualstudio.com/docs/extensions/testing-extensions#_running-tests-automatically-on-travis-ci-build-machines).
    @john-patterson
    john-patterson committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    ebf9a0b View commit details
    Browse the repository at this point in the history