adds CHANGELOG entry for PR 2322 #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-patterson
force-pushed
the
jopatte/2322-changlog-entry
branch
from
1538b7e
to
fd50c99
Compare
bobbrow
requested changes
Jul 25, 2018
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Version 0.17.8: August 16, 2018 | |||
| * Add `inactiveRegionForegroundColor` and `inactiveRegionBackgroundColor` to settings. [#2212](https://github.com/Microsoft/vscode-cpptools/issues/2212) | |||
| * Add multi-pass environment variable resolution allowing variables defined in terms of other variables. [#2322](https://github.com/Microsoft/vscode-cpptools/pull/2322) | |||
There was a problem hiding this comment.
We usually just try to do one line per github issue. I would just keep this first line and remove the rest.
Realized I had left out the CHANGELOG update. For [PR 2322](microsoft#2322).
john-patterson
force-pushed
the
jopatte/2322-changlog-entry
branch
from
fd50c99
to
3a7da84
Compare
|
What was the 2nd line? I don't see it. |
|
@sean-mcmanus I had overwritten it with push -f, I had a line for the following: |
bobbrow
approved these changes
Jul 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized I had left out the CHANGELOG update. For PR 2322.