Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings for auto pch #3184

Merged
merged 9 commits into from
Feb 25, 2019
Merged

Add settings for auto pch #3184

merged 9 commits into from
Feb 25, 2019

Conversation

michelleangela
Copy link
Contributor

Add these settings for auto pch:

  1. Cache path
  2. Cache size

sean-mcmanus
sean-mcmanus previously requested changes Feb 19, 2019
View reviewed changes
Extension/package.json Outdated
@@ -308,6 +308,19 @@
"description": "Determines whether pop up notifications will be shown when a configuration provider extension is unable to provide a configuration for a source file.",
"scope": "resource"
},
"C_Cpp.intelliSense.cachePath": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming style seems inconsistent with our existing settings like intelliSenseEngine, intelliSenseMode, and intelliSenseEngineFallback.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we were trying to be forward-looking, but I agree this might be premature.
We should rename these intelliSenseCachePath and intelliSenseCacheSize.

bobbrow
bobbrow requested changes Feb 22, 2019
View reviewed changes
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
@bobbrow bobbrow dismissed sean-mcmanus’s stale review February 22, 2019 22:36

issue resolved in latest

@bobbrow bobbrow merged commit 361ca45 into master Feb 25, 2019
@bobbrow bobbrow deleted the mimatias/add_pch_settings branch February 25, 2019 22:51
@LinAGKar
Copy link

Does intelliSenseCachePath need to be unique per workspace, or can it be set to a global location? Really, on Linux it should point to somewhere in XDG_CACHE_HOME by default.

@bobbrow
Copy link
Member

bobbrow commented Mar 22, 2019

We were emulating Visual Studio which sets this per project, but you can certainly set C_Cpp.intelliSenseCachePath to a global location that all projects share.

@renkun-ken
Copy link

It looks like C_Cpp.intelliSenseCachePath currently does not translate environment variables like ${env:HOME} so that I can put these files somewhere into my home folder. I'm not sure if I'm missing something?

@sean-mcmanus
Copy link
Contributor

@renkun-ken It's a bug -- we have a fix at #3368 for our next release.

@renkun-ken
Copy link

Thanks, @sean-mcmanus!

@LinAGKar
Copy link

LinAGKar commented Mar 27, 2019 •
edited
Loading

~/.cache/vscode/ does not seem to work either. Also, the setting says that there is a fallback if an invalid path is given, but there is no indication whether the currently set path is considered valid.

@bobbrow
Copy link
Member

bobbrow commented Mar 28, 2019

@LinAGKar, it's the same bug as ${env:HOME} and will be fixed in the next release.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grdowns grdowns grdowns left review comments

@bobbrow bobbrow bobbrow approved these changes

@sean-mcmanus sean-mcmanus Awaiting requested review from sean-mcmanus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michelleangela @LinAGKar @bobbrow @renkun-ken @sean-mcmanus @grdowns