Add command to log language service diagnostics #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cpptools into dev/coleng/diag
michelleangela
approved these changes
Apr 18, 2019
sean-mcmanus
approved these changes
Apr 18, 2019
sean-mcmanus
approved these changes
Apr 19, 2019
bobbrow
reviewed
Apr 19, 2019
| } | ||
| let header: string = `-------- Diagnostics - ${new Date().toLocaleString()}\n`; | ||
| let version: string = `Version: ${util.packageJson.version}\n`; | ||
| this.diagnosticsChannel.appendLine(`${header}${version}${response.diagnostics}`); |
There was a problem hiding this comment.
Is there an API to "show" or "focus" the output channel to ensure that the user can see the output when we log it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LogDiagnostics command. Logs to new diagnostics channel. Uses new GetDiagnostics request.