Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of detected compiler paths to IntelliSense config UI #3708

Merged
merged 5 commits into from
May 30, 2019

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented May 28, 2019

Change input field of compiler path to editable drop-down list. This list will show detected compiler paths.

Screenshots
compilerpathlist

compilerpathlis-editt

compilerpathlis-errort

@michelleangela michelleangela requested a review from a team May 28, 2019 22:48
@michelleangela
Copy link
Contributor Author

Verified UI on Linux and Mac

@sean-mcmanus
Copy link
Collaborator

Can you normalize the / and \\ in the dropdown list of compilers? Maybe using the "C_Cpp.preferredPathSeparator"?

@sean-mcmanus
Copy link
Collaborator

Can you increase the top margin in the dropdown? It seems too little top margin in the screenshot.

Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

@michelleangela
Copy link
Contributor Author

michelleangela commented May 29, 2019

Can you increase the top margin in the dropdown? It seems too little top margin in the screenshot.

Styling the dropdown is not straightforward. Haven't been able to figure out it. Will need to research and look into VS Code repo. The dropdown style is the same on the existing dropdowns.

@sean-mcmanus
Copy link
Collaborator

Styling the dropdown is not straightforward. Haven't been able to figure out it. Will need to research and look into VS Code repo. The dropdown style is the same on the existing dropdowns.

Isn't it just the style margins or something? I remember changing some of the margins with other UI a few weeks ago. Oh, looks like the existing dropdowns have the same issue, i.e. we've shipped like this already...I just never noticed.

@michelleangela
Copy link
Contributor Author

michelleangela commented May 30, 2019

Styling the dropdown is not straightforward. Haven't been able to figure out it. Will need to research and look into VS Code repo. The dropdown style is the same on the existing dropdowns.

Isn't it just the style margins or something? I remember changing some of the margins with other UI a few weeks ago. Oh, looks like the existing dropdowns have the same issue, i.e. we've shipped like this already...I just never noticed.

The HTML select and option elements cannot be styled the same way as the other elements. The style depends on the OS, and requires more than CSS to modify the native style. As the current native style works for now, we can change the style later to look like VS Code after we've put in more features/functionalities on the config UI.

@michelleangela michelleangela merged commit c60a2c6 into master May 30, 2019
@michelleangela michelleangela deleted the mimatias/config-ui-knowncompilers branch May 30, 2019 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants