Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration UI - V2 #3732

Merged
merged 13 commits into from
Jun 7, 2019
Merged

Configuration UI - V2 #3732

merged 13 commits into from
Jun 7, 2019

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Jun 5, 2019 •
edited
Loading

  • Enable editing different configuration by selecting a different configuration name from a dropdown menu. Note that selecting a different configuration on the UI editor does not change the "Active Configuration" for the current workspace folder.
  • Enable adding new configuration with default values for current platform
  • Add "Advanced Settings" section to edit advanced configuration settings

Screenshots

advanced-settings-collapsed

advanced-settings-expanded

@michelleangela michelleangela requested review from a team and tara-raj June 5, 2019 19:51
sean-mcmanus
sean-mcmanus requested changes Jun 5, 2019
View reviewed changes
Extension/ui/settings.ts Outdated Show resolved Hide resolved
Extension/ui/settings.html Show resolved Hide resolved
Extension/ui/settings.html Outdated Show resolved Hide resolved
@michelleangela michelleangela merged commit 90c6e98 into master Jun 7, 2019
@bobbrow bobbrow deleted the mimatias/edit-multi-config branch June 7, 2019 23:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tara-raj tara-raj Awaiting requested review from tara-raj

@sean-mcmanus sean-mcmanus Awaiting requested review from sean-mcmanus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michelleangela @sean-mcmanus